Fix panic when call cleanupMap twice - #289
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoSep 7, 2026
Merged
Conversation
theop-dd
force-pushed
the
theop-dd/fix-panic-clear-map
branch
from
September 4, 2026 14:34
185db5e to
a697951
Compare
brycekahle
approved these changes
Sep 4, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
theop-dd/fix-panic-clear-map
branch
September 7, 2026 07:19
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix a panic that was introduced by the previous PR.
Before, when the function
Stopwas not splitted, this could not happen since the state was checked at the beginning of the function. We know need to check it in both functions.Motivation
Calling 2 times cleanupMap could panic since we try to close a map that was already close.
What inspired you to submit this pull request?